Add ARM32/ARM64 CI

[sipa]

No description provided.

[real-or-random]

ACK mod nit

[real-or-random]

Wait, the expectation was probably that this should break due to #931.

I think this is related to the "shortcut" in configure.ac that simply uses the native toolchain to build gen_context when we're not cross-compiling. In this case, we are cross compiling, so we don't take that shortcut.

I'll have a look.

[real-or-random]

Wait, the expectation was probably that this should break due to #931.

I think this is related to the "shortcut" in configure.ac that simply uses the native toolchain to build gen_context when we're not cross-compiling. In this case, we are cross compiling, so we don't take that shortcut.

I'll have a look.

Ok I think I was a little confused when I wrote that. The issue #931 appears when compiling gen_context for the build machine. On CI, we cross-compile for ARM, so building gen_context for the CI machine is never an issue.

I think no simple CI test could test for the breakage in #931. We could of course cross-compile gen_context and then run it on qemu.

One possible way to do so without fiddling around with the build system would be to rely on binfmt_misc, a kernel feature which allows you to run commands like ./cmd which then will be automatically wrapped, e.g., by qemu or wine. (This is why my machine will build and run gen_context.exe when cross-compiling for mingw...) But I heard binfmt_misc has some issues with Docker.

Another possible way is to simply add a CI job that manually cross-compiles gen_context for ARM and runs it on qemu. But this doesn't really test if the autoconf build works.

So I'm not convinced that testing this on CI is worth the hassle.

Anyway, my ACK on this PR is still valid.

[sipa]

Indeed, I realized too late that #931 was in fact related to the build environment for gen_context rather than the ARM asm per se.

Still, these are very useful CI targets I think.

[real-or-random]

Still, these are very useful CI targets I think.

For sure, and this fixes #598.

edit: By the way, I'm happy to see that it really wasn't a lot of work to add this build and the mingw build. So it seems that the general structure of the CI is pretty portable and adding qemu buils is simply a matter of installing the right Debian packages and passing the right HOST.

[gmaxwell]

if this supports a full docker environment could we just run qemu-system and run a whole emulated distribution? :P That said, having a cross compile to arm test is really really good too.

[sipa]

@gmaxwell I think that's an option, but something I'd like to keep for later.

[real-or-random]

ACK 8bbad7a CI output looks fine

[jonasnick]

ACK 8bbad7a