-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make signing table fully static #988
Merged
real-or-random
merged 18 commits into
bitcoin-core:master
from
real-or-random:202108-prebuilt-gen-context
Dec 15, 2021
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
22dc2c0
ecmult_gen: Move table creation to new file and force static prec
real-or-random e43ba02
refactor: Decouple table generation and ecmult_gen context
real-or-random 3b0c218
ecmult_gen: Simplify ecmult_gen context after making table static
real-or-random 00d2fa1
ecmult_gen: Make code consistent with comment
real-or-random 8ae18f1
refactor: Rename file that contains static ecmult_gen table
real-or-random 9ad09f6
refactor: Rename program that generates static ecmult_gen table
real-or-random e1a7653
refactor: Make generator a parameter of ecmult_gen_create_prec_table
real-or-random 5106226
exhaustive_tests: Fix with ecmult_gen table with custom generator
real-or-random 4c94c55
doc: Remove obsolete hint for valgrind stack size
real-or-random a4875e3
refactor: Move default callbacks to util.h
real-or-random fdb33dd
refactor: Make PREC_BITS a parameter of ecmult_gen_build_prec_table
real-or-random 5eba83f
ecmult_gen: Precompute tables for all values of ECMULT_GEN_PREC_BITS
real-or-random 6573c08
ecmult_gen: Tidy precomputed file and save space
real-or-random ac49361
prealloc: Get rid of manual memory management for prealloc contexts
real-or-random ad63bb4
build: Prebuild and distribute ecmult_gen table
real-or-random d94a37a
build: Remove CC_FOR_BUILD stuff
real-or-random bb36fe9
ci: Test `make precomp`
real-or-random 7dfcece
build: Remove #undef hack for ASM in the precomputation programs
real-or-random File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
src/ecmult_static_pre_g.h linguist-generated | ||
src/ecmult_gen_static_prec_table.h linguist-generated |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(No action needed) It's too bad that
gen
stands for both "generate" (the static table) and "generator" (of a group) 😅 , but it's probably not worth changing, especially not as part of this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this confused me a lot when starting to work on the library a few years back. And
gen_context
should have been calledgen_gen_context
at least, even though that's ugly.I tried to avoid this discussion in this PR (only renaming thins I'm touching anyway) and it may be worth unifying the names in the follow-up PR that switches to linking instead of including (e.g., I intentionally used "create" in a function name instead of "generate") Then we anyway need to touch both "generate" things again, so this would be a good opportunity.