Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit chapter 14 #37

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Conversation

edilmedeiros
Copy link
Contributor

I'll keep this as a draft for now, see #36.

@sb1752
Copy link
Collaborator

sb1752 commented Jun 5, 2024

Yeah if you want to go ahead and update the output in this PR based on that issue that's fine by me

@edilmedeiros
Copy link
Contributor Author

Right, fixed the console messages.
Note that I also added a -testnet flag to the bitcoin-cli tool since this is a testnet transaction.
Finally, dropped any references to script_sig variables (see #39).

14_json_serialization.md Outdated Show resolved Hide resolved
@edilmedeiros
Copy link
Contributor Author

Removed the commit with the -testnet flag.

@sb1752
Copy link
Collaborator

sb1752 commented Jun 10, 2024

Ack d5cccf7

Perfect thank you

@sb1752 sb1752 merged commit ca2b9a3 into bitcoin-dev-project:main Jun 10, 2024
This was referenced Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants