Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spv 775) refactor the codebase and sync its functionality with the current state of the js client #225

Conversation

ac4ch
Copy link
Contributor

@ac4ch ac4ch commented May 14, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Copy link
Contributor

github-actions bot commented May 14, 2024

Manual Tests

πŸ’š Manual testing by @Nazarii-4chain resulted in success.

@ac4ch ac4ch marked this pull request as ready for review May 14, 2024 12:38
@ac4ch ac4ch requested a review from a team as a code owner May 14, 2024 12:38
http.go Outdated Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
client_options.go Outdated Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
client_options.go Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
client_options.go Outdated Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
client_options.go Outdated Show resolved Hide resolved
client_options.go Outdated Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
client_options.go Outdated Show resolved Hide resolved
client_options.go Outdated Show resolved Hide resolved
client_options.go Outdated Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
examples/http/http.go Outdated Show resolved Hide resolved
walletclient.go Outdated Show resolved Hide resolved
access_keys_test.go Outdated Show resolved Hide resolved
client_options.go Show resolved Hide resolved
transactions_test.go Outdated Show resolved Hide resolved
…its_functionality_with_the_current_state_of_the_js-client
@Nazarii-4chain Nazarii-4chain added the tested PR was tested by a team member label May 17, 2024
@ac4ch ac4ch merged commit ab378a1 into main May 17, 2024
6 checks passed
@ac4ch ac4ch deleted the feat/SPV-775/Refactor_the_codebase_and_sync_its_functionality_with_the_current_state_of_the_js-client branch May 17, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants