Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BUX-641) Shared- & Public- config #64

Merged
merged 9 commits into from
Mar 13, 2024
Merged

feat(BUX-641) Shared- & Public- config #64

merged 9 commits into from
Mar 13, 2024

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Mar 7, 2024 •
edited
Loading

-web-backend fetches SharedConfig from spv-wallet checks it, and based on it, makes a PublicConfig which is designed to be exposed for frontend apps.
bitcoin-sv/spv-wallet#496

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @kuba-4chain resulted in success.

@chris-4chain chris-4chain marked this pull request as ready for review March 7, 2024 14:20
@chris-4chain chris-4chain requested a review from a team as a code owner March 7, 2024 14:20
chris-4chain
chris-4chain commented Mar 12, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
dorzepowski
dorzepowski requested changes Mar 12, 2024
View reviewed changes
transports/http/endpoints/api/config/endpoints.go Outdated Show resolved Hide resolved
domain/config/config_service.go Outdated Show resolved Hide resolved
domain/config/config_service.go Show resolved Hide resolved
dorzepowski
dorzepowski previously approved these changes Mar 12, 2024
View reviewed changes
@kuba-4chain kuba-4chain added the tested PR was tested by a team member label Mar 13, 2024
@kuba-4chain kuba-4chain added tested PR was tested by a team member and removed tested PR was tested by a team member labels Mar 13, 2024
@chris-4chain chris-4chain merged commit 6900bc7 into main Mar 13, 2024
5 of 6 checks passed
@chris-4chain chris-4chain deleted the feat-641-shared-config branch March 13, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorzepowski dorzepowski dorzepowski approved these changes

Assignees
No one assigned
Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-4chain @dorzepowski @kuba-4chain