refactor(BUX-566): fix lint errors

metrics/metrics.go

@@ -7,11 +7,13 @@ import (
 	"github.com/prometheus/client_golang/prometheus/promhttp"
 )
 
+// Metrics is the metrics collector
 type Metrics struct {
 	gatherer   prometheus.Gatherer
 	registerer prometheus.Registerer
 }
 
+// newMetrics will create a new Metrics object; this is private to ensure only one, global instance is created
 func newMetrics() *Metrics {
 	registry := prometheus.NewRegistry()
 	constLabels := prometheus.Labels{"app": appName}
@@ -25,6 +27,7 @@ func newMetrics() *Metrics {
 	return m
 }
 
-func (m *Metrics) HttpHandler() http.Handler {
+// HTTPHandler will return the http.Handler for the metrics
+func (m *Metrics) HTTPHandler() http.Handler {
 	return promhttp.HandlerFor(metrics.gatherer, promhttp.HandlerOpts{Registry: metrics.registerer})
 }

server/server.go

@@ -91,7 +91,7 @@ func (s *Server) Handlers() *nrhttprouter.Router {
 	s.Router.HTTPRouter.Handler(http.MethodGet, "/swagger", http.RedirectHandler("/swagger/index.html", http.StatusMovedPermanently))
 	s.Router.HTTPRouter.Handler(http.MethodGet, "/swagger/*any", httpSwagger.WrapHandler)
 	if metrics, enabled := metrics.Get(); enabled {
-		s.Router.HTTPRouter.Handler(http.MethodGet, "/metrics", metrics.HttpHandler())
+		s.Router.HTTPRouter.Handler(http.MethodGet, "/metrics", metrics.HTTPHandler())
 	}
 	segment.End()