Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BUX-84): run bux server with single command #268

Merged
merged 1 commit into from
Aug 1, 2023
Merged

feat(BUX-84): run bux server with single command #268

merged 1 commit into from
Aug 1, 2023

Conversation

dorzepowski
Copy link
Contributor

No description provided.

@dorzepowski dorzepowski requested a review from mrz1836 as a code owner July 31, 2023 14:12
@mergify mergify bot added the feature Any new significant addition label Jul 31, 2023
mrz1836
mrz1836 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrz1836
Copy link
Contributor

mrz1836 commented Jul 31, 2023

@dorzepowski the last test failed in the linter, might be something simple, not sure yet.

@dorzepowski
Copy link
Contributor Author

I have similar output of command make test-ci-no-race on master
And it seems that update of go-datastore introduced this issue
because when I switched to commit before updating go-datastore make test-ci-no-race is passing on my machine

@mrz1836
Copy link
Contributor

mrz1836 commented Aug 1, 2023

@dorzepowski I will merge, even though the tests are not passing, and I will try to fix it

@mrz1836 mrz1836 merged commit 9776cf5 into bitcoin-sv:master Aug 1, 2023
@proapi proapi deleted the feat/single_command_to_run_bux_server branch August 29, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrz1836 mrz1836 mrz1836 approved these changes

Assignees

@mrz1836 mrz1836

Labels
feature Any new significant addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dorzepowski @mrz1836 @pawellewandowski98