Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BUX-51): minercraft_api and minercraft_custom_apis in config #272

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

witalij-4chain
Copy link
Contributor

minercraft_api and minercraft_custom_apis for bux-server configuration.
mApi or Arc(case insensitive) can be used for minercraft_api
Screenshot 2023-08-05 at 23 20 54
Screenshot 2023-08-05 at 23 21 10
Miner's configuration can be overwritten by minercraft_custom_apis
Screenshot 2023-08-05 at 23 20 15

@witalij-4chain witalij-4chain requested a review from mrz1836 as a code owner August 5, 2023 21:21
@mergify mergify bot assigned mrz1836 Aug 5, 2023
@mergify mergify bot added the feature Any new significant addition label Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #272 (b7e8634) into master (773234c) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   32.48%   32.48%           
=======================================
  Files          41       41           
  Lines        1373     1382    +9     
=======================================
+ Hits          446      449    +3     
- Misses        905      909    +4     
- Partials       22       24    +2     
Flag Coverage Δ
unittests 32.48% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
config/config.go 100.00% <ø> (ø)
config/services.go 33.83% <33.33%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 773234c...b7e8634. Read the comment docs.

Copy link
Contributor

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit aa10d21 into bitcoin-sv:master Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants