Fix: unreserve utxos #286
Merged
Fix: unreserve utxos #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to our open-source project @arkadiuszos4chain! 💘 |
mrz1836
suggested changes
Aug 23, 2023
mrz1836
suggested changes
Aug 24, 2023
There was a problem hiding this comment.
Merge conflict, probably with the bux version vs dependabot. @arkadiuszos4chain @pawellewandowski98
|
@arkadiuszos4chain linter failed, few fixes required. |
|
Going to merge and fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Creation of a draft transaction will mark UTXOs as reserved, and those UTXOs can't be used for another transaction.
If a draft transaction was created, but the "record transaction" process failed, UTXOs will still be reserved and can't be used for another payment.
A mechanism for unreserving UTXOs should be added for such cases.
PR includes: