Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BUX-200): unify logs #365

Merged
merged 8 commits into from
Dec 13, 2023
Merged

feat(BUX-200): unify logs #365

merged 8 commits into from
Dec 13, 2023

Conversation

pawellewandowski98
Copy link
Contributor

Description

  1. Changed logger to zerolog
  2. Added new config option logging:
  • level - defines logger level
  • format - json/console defines format of logs
  • instance_name - defines name of the instance which will be written inside logs
  • log_origin - add or not information about place where log was called

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@pawellewandowski98 pawellewandowski98 self-assigned this Dec 8, 2023
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner December 8, 2023 14:47
@mergify mergify bot added the feature Any new significant addition label Dec 8, 2023
Copy link
Contributor

mergify bot commented Dec 8, 2023

Welcome to our open-source project @pawellewandowski98! 💘

actions/graphql/routes.go Outdated Show resolved Hide resolved
cmd/server/main.go Outdated Show resolved Hide resolved
cmd/server/main.go Outdated Show resolved Hide resolved
config/load.go Show resolved Hide resolved
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #365 (b562480) into master (6b04a03) will decrease coverage by 0.38%.
The diff coverage is 5.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
- Coverage   34.33%   33.95%   -0.38%     
==========================================
  Files          42       42              
  Lines        1436     1437       +1     
==========================================
- Hits          493      488       -5     
- Misses        917      921       +4     
- Partials       26       28       +2     
Flag Coverage Δ
unittests 33.95% <5.88%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
config/config.go 100.00% <ø> (ø)
config/load.go 72.00% <ø> (+1.26%) ⬆️
server/server.go 6.17% <0.00%> (+0.29%) ⬆️
config/services.go 40.70% <6.25%> (-1.97%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b04a03...b562480. Read the comment docs.

@mergify mergify bot merged commit 22aa386 into master Dec 13, 2023
9 of 10 checks passed
@mergify mergify bot deleted the feat-200-unify-logs branch December 13, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants