Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(BUX-416) disable monitor #380

Merged
merged 3 commits into from
Dec 21, 2023
Merged

chore(BUX-416) disable monitor #380

merged 3 commits into from
Dec 21, 2023

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Dec 21, 2023

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

According to changes in BuxOrg/bux#513 - the monitor config and usage of WithMonitor*** functions has been removed.

@chris-4chain chris-4chain requested a review from a team as a code owner December 21, 2023 11:19
@mergify mergify bot added the update General updates label Dec 21, 2023
Copy link
Contributor

mergify bot commented Dec 21, 2023

Welcome to our open-source project @chris-4chain! πŸ’˜

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (f05760d) 39.23% compared to head (e8bbc00) 39.06%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
- Coverage   39.23%   39.06%   -0.17%     
==========================================
  Files          44       44              
  Lines        1611     1577      -34     
==========================================
- Hits          632      616      -16     
+ Misses        944      928      -16     
+ Partials       35       33       -2     
Flag Coverage Ξ”
unittests 39.06% <ΓΈ> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
config/config.go 100.00% <ΓΈ> (ΓΈ)
config/defaults.go 100.00% <ΓΈ> (ΓΈ)
config/services.go 44.59% <ΓΈ> (+2.12%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update f05760d...e8bbc00. Read the comment docs.

@mergify mergify bot merged commit c2311ca into master Dec 21, 2023
10 checks passed
@mergify mergify bot deleted the chore-416-disable-monitor branch December 21, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update General updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants