Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BUX-417): remove unused env #408

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

pawellewandowski98
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Description

  • Removed Default note and SkipInitializeWithVersion

@pawellewandowski98 pawellewandowski98 self-assigned this Jan 16, 2024
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner January 16, 2024 09:25
Copy link
Contributor

mergify bot commented Jan 16, 2024

Welcome to our open-source project @pawellewandowski98! πŸ’˜

@mergify mergify bot added the feature Any new significant addition label Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (ad2f9d0) 40.49% compared to head (468d2af) 40.38%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           rc-v1.1     #408      +/-   ##
===========================================
- Coverage    40.49%   40.38%   -0.11%     
===========================================
  Files           46       46              
  Lines         1662     1659       -3     
===========================================
- Hits           673      670       -3     
  Misses         949      949              
  Partials        40       40              
Flag Coverage Ξ”
unittests 40.38% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
config/config.go 100.00% <ΓΈ> (ΓΈ)
config/defaults.go 100.00% <100.00%> (ΓΈ)
config/services.go 43.00% <ΓΈ> (-0.20%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update ad2f9d0...468d2af. Read the comment docs.

@pawellewandowski98 pawellewandowski98 merged commit 7b13b4f into rc-v1.1 Jan 16, 2024
8 checks passed
@mergify mergify bot deleted the feat-417-remove-unused-env branch January 16, 2024 12:41
wregulski pushed a commit that referenced this pull request Jan 31, 2024
* chore(BUX-417): remove DefaultNote and SkipInitializeWithVersion

* chore(BUX-417): update bux version
wregulski pushed a commit that referenced this pull request Feb 2, 2024
* chore(BUX-417): remove DefaultNote and SkipInitializeWithVersion

* chore(BUX-417): update bux version
jakubmkowalski pushed a commit that referenced this pull request Feb 13, 2024
* chore(BUX-417): remove DefaultNote and SkipInitializeWithVersion

* chore(BUX-417): update bux version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants