Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bux-398/ get waiting contacts #490

Merged
merged 12 commits into from
Mar 13, 2024
Merged

Conversation

Nazarii-4chain
Copy link
Contributor

@Nazarii-4chain Nazarii-4chain commented Mar 4, 2024

Added GetContacts action,
removed unused files,
change to ShouldBindJson method in contact creation,
Optimized newContact arguments,
adjusted ContactService interface,
changed id generation in contact model,
added tests,
added getContacts handler

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

…son method in contact creation, Optimized newContact arguments, adjusted ContactService interface, changed id generation in contact model, added tests, added getContacts handler
@Nazarii-4chain Nazarii-4chain requested a review from a team as a code owner March 4, 2024 15:55
@Nazarii-4chain Nazarii-4chain self-assigned this Mar 4, 2024
Copy link

github-actions bot commented Mar 4, 2024

Manual Tests

💚 Manual testing by @arkadiuszos4chain resulted in success.

actions/contacts/create.go Outdated Show resolved Hide resolved
actions/contacts/create.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 24.13793% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 52.78%. Comparing base (e88eba0) to head (314b572).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
- Coverage   52.97%   52.78%   -0.20%     
==========================================
  Files         164      165       +1     
  Lines        9027     9071      +44     
==========================================
+ Hits         4782     4788       +6     
- Misses       3793     3829      +36     
- Partials      452      454       +2     
Flag Coverage Δ
unittests 52.78% <24.13%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
actions/contacts/routes.go 100.00% <100.00%> (ø)
engine/model_contact.go 47.72% <75.00%> (+0.22%) ⬆️
actions/contacts/create.go 0.00% <0.00%> (ø)
engine/action_contact.go 0.00% <0.00%> (ø)
actions/contacts/search.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88eba0...314b572. Read the comment docs.

@arkadiuszos4chain arkadiuszos4chain added the tested PR was tested by a team member label Mar 13, 2024
@arkadiuszos4chain arkadiuszos4chain merged commit bed3503 into master Mar 13, 2024
6 checks passed
@arkadiuszos4chain arkadiuszos4chain deleted the BUX-398/GetWaitingContacts branch March 13, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants