-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bux-398/ get waiting contacts #490
Conversation
…son method in contact creation, Optimized newContact arguments, adjusted ContactService interface, changed id generation in contact model, added tests, added getContacts handler
Manual Tests💚 Manual testing by @arkadiuszos4chain resulted in success. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #490 +/- ##
==========================================
- Coverage 52.97% 52.78% -0.20%
==========================================
Files 164 165 +1
Lines 9027 9071 +44
==========================================
+ Hits 4782 4788 +6
- Misses 3793 3829 +36
- Partials 452 454 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Added GetContacts action,
removed unused files,
change to ShouldBindJson method in contact creation,
Optimized newContact arguments,
adjusted ContactService interface,
changed id generation in contact model,
added tests,
added getContacts handler
Pull Request Checklist