Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(BUX-641): remove unneeded config param for frontend in start.sh #503

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

dorzepowski
Copy link
Contributor

@dorzepowski dorzepowski commented Mar 13, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@dorzepowski dorzepowski requested a review from a team as a code owner March 13, 2024 12:29
Copy link

github-actions bot commented Mar 13, 2024

Manual Tests

πŸ’š Manual testing by @chris-4chain resulted in success.

@chris-4chain
Copy link
Contributor

testing πŸ§ͺ

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 53.03%. Comparing base (c8dffdf) to head (606e498).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #503   +/-   ##
=======================================
  Coverage   53.03%   53.03%           
=======================================
  Files         164      164           
  Lines        9020     9020           
=======================================
  Hits         4784     4784           
  Misses       3785     3785           
  Partials      451      451           
Flag Coverage Ξ”
unittests 53.03% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update c8dffdf...606e498. Read the comment docs.

@chris-4chain chris-4chain added the tested PR was tested by a team member label Mar 13, 2024
@dorzepowski dorzepowski merged commit 54766c4 into master Mar 13, 2024
6 of 7 checks passed
@dorzepowski dorzepowski deleted the chore/bux-641-remove-fe-config-param branch March 13, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants