Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SPV-1071): cleanup in config package. #722

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Conversation

dorzepowski
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@dorzepowski dorzepowski requested a review from a team as a code owner October 4, 2024 11:06
Copy link

github-actions bot commented Oct 4, 2024

Manual Tests

πŸ’š Manual testing by @chris-4chain resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 26.55367% with 260 lines in your changes missing coverage. Please review.

Project coverage is 45.85%. Comparing base (62ba56c) to head (436661e).

Files with missing lines Patch % Lines
config/config_to_options.go 0.00% 181 Missing ⚠️
cmd/main.go 0.00% 26 Missing ⚠️
server/server.go 10.52% 17 Missing ⚠️
logging/logging.go 0.00% 11 Missing ⚠️
config/check_block_header_service.go 0.00% 5 Missing ⚠️
config/load_config.go 64.28% 2 Missing and 3 partials ⚠️
config/validate_arc.go 87.87% 2 Missing and 2 partials ⚠️
engine/logging/adapters.go 20.00% 4 Missing ⚠️
config/config.go 0.00% 2 Missing ⚠️
engine/client.go 0.00% 1 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   46.37%   45.85%   -0.52%     
==========================================
  Files         314      314              
  Lines       13049    13047       -2     
==========================================
- Hits         6051     5983      -68     
- Misses       6417     6508      +91     
+ Partials      581      556      -25     
Flag Coverage Ξ”
unittests 45.85% <26.55%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
config/defaults.go 100.00% <100.00%> (ΓΈ)
config/validate_app_config.go 100.00% <100.00%> (ΓΈ)
logging/gin_loggers.go 63.41% <100.00%> (ΓΈ)
server/middleware/appcontext_middleware.go 100.00% <100.00%> (ΓΈ)
tests/tests.go 100.00% <100.00%> (+12.00%) ⬆️
config/flags.go 42.10% <75.00%> (ΓΈ)
config/config.go 50.00% <0.00%> (-50.00%) ⬇️
engine/client.go 55.73% <0.00%> (-0.93%) ⬇️
engine/tester/logger.go 0.00% <0.00%> (ΓΈ)
config/validate_arc.go 87.87% <87.87%> (ΓΈ)
... and 7 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 62ba56c...436661e. Read the comment docs.

config.example.yaml Outdated Show resolved Hide resolved
logging/logging.go Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
config/config_to_options.go Outdated Show resolved Hide resolved
config/config_to_options.go Outdated Show resolved Hide resolved
config/config_to_options.go Outdated Show resolved Hide resolved
config/config_to_options.go Show resolved Hide resolved
config/config_to_options.go Show resolved Hide resolved
config/load_test.go Outdated Show resolved Hide resolved
config/config_to_options.go Outdated Show resolved Hide resolved
logging/logging.go Show resolved Hide resolved
tests/tests.go Outdated Show resolved Hide resolved
@dorzepowski dorzepowski added the regression-tests Runs regression tests label Oct 4, 2024
@chris-4chain chris-4chain added the tested PR was tested by a team member label Oct 4, 2024
@dorzepowski dorzepowski merged commit ce45722 into main Oct 7, 2024
18 of 19 checks passed
@dorzepowski dorzepowski deleted the refactor/config branch October 7, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-tests Runs regression tests tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants