Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1248) add domain check for paymail entry #828

Merged
merged 9 commits into from
Jan 16, 2025

Conversation

cain4chain
Copy link
Contributor

@cain4chain cain4chain commented Dec 20, 2024

  • feat(paymail) add checkPaymailDomain function for domain validation
  • feat(error) add error definition to engine code for invalid domain
  • chore(paymailCreateAddress) add logic for domain validation check

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

feat(paymail) add checkPaymailDomain function for domain validation
feat(error) add error definition to engine code for invalid domain
chore(paymailCreateAddress) add logic for domain validation check
@cain4chain cain4chain added the chore Simple updates or version bumps label Dec 20, 2024
@cain4chain cain4chain self-assigned this Dec 20, 2024
@cain4chain cain4chain requested a review from a team as a code owner December 20, 2024 11:09
Copy link

github-actions bot commented Dec 20, 2024

Manual Tests

💚 Manual testing by @chris-4chain resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.

Project coverage is 46.44%. Comparing base (1c1f102) to head (d67c3a1).

Files with missing lines Patch % Lines
actions/admin/paymail_addresses_old.go 0.00% 7 Missing ⚠️
actions/admin/paymail_addresses.go 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
+ Coverage   46.00%   46.44%   +0.43%     
==========================================
  Files         379      379              
  Lines       18203    18217      +14     
==========================================
+ Hits         8375     8461      +86     
+ Misses       9198     9116      -82     
- Partials      630      640      +10     
Flag Coverage Δ
unittests 46.44% <21.42%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
actions/admin/paymail_addresses.go 56.07% <42.85%> (+56.07%) ⬆️
actions/admin/paymail_addresses_old.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1f102...d67c3a1. Read the comment docs.

actions/admin/paymail_addresses_old.go Outdated Show resolved Hide resolved
chris-4chain and others added 6 commits January 14, 2025 09:42
- Chore (checkPaymailDomain) Remove checkPaymailDomain funciton
- Chore (paymailCreateAddress) Use "slices" method for checking Domain values
- Chore (checkPaymailDomain) Remove checkPaymailDomain funciton
- Chore (paymailCreateAddress) Use "slices" method for checking Domain values
feat(test) - add test to remove paymail as admin and check that the paymail was removed. try to remove paymail as non admin should fail
@chris-4chain chris-4chain added the tested PR was tested by a team member label Jan 16, 2025
@cain4chain cain4chain merged commit f69d82d into main Jan 16, 2025
21 checks passed
@cain4chain cain4chain deleted the feat(SPV-1248)-add-domain-check-for-paymail-entry branch January 16, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Simple updates or version bumps tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants