-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SPV-1248) add domain check for paymail entry #828
feat(SPV-1248) add domain check for paymail entry #828
Conversation
feat(paymail) add checkPaymailDomain function for domain validation feat(error) add error definition to engine code for invalid domain chore(paymailCreateAddress) add logic for domain validation check
Manual Tests💚 Manual testing by @chris-4chain resulted in success. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
==========================================
+ Coverage 46.00% 46.44% +0.43%
==========================================
Files 379 379
Lines 18203 18217 +14
==========================================
+ Hits 8375 8461 +86
+ Misses 9198 9116 -82
- Partials 630 640 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
- Chore (checkPaymailDomain) Remove checkPaymailDomain funciton - Chore (paymailCreateAddress) Use "slices" method for checking Domain values
- Chore (checkPaymailDomain) Remove checkPaymailDomain funciton - Chore (paymailCreateAddress) Use "slices" method for checking Domain values
…ttps://github.com/bitcoin-sv/spv-wallet into feat(SPV-1248)-add-domain-check-for-paymail-entry
feat(test) - add test to remove paymail as admin and check that the paymail was removed. try to remove paymail as non admin should fail
chore(lint-styles): fix linting issues
Pull Request Checklist