Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1300): experimental new tx flow feature flag #829

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

chris-4chain
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@chris-4chain chris-4chain requested a review from a team as a code owner December 20, 2024 11:47
Copy link

github-actions bot commented Dec 20, 2024

Manual Tests

πŸ’š Manual testing by @wregulski resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 53.96825% with 29 lines in your changes missing coverage. Please review.

Project coverage is 45.92%. Comparing base (1acad0e) to head (adb4b66).

Files with missing lines Patch % Lines
engine/paymail/paymail_service_provider.go 0.00% 17 Missing ⚠️
engine/client_options.go 20.00% 4 Missing ⚠️
config/config_to_options.go 0.00% 3 Missing ⚠️
engine/client_internal.go 81.25% 1 Missing and 2 partials ⚠️
engine/client.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
- Coverage   45.96%   45.92%   -0.05%     
==========================================
  Files         369      371       +2     
  Lines       17820    17856      +36     
==========================================
+ Hits         8191     8200       +9     
- Misses       9022     9047      +25     
- Partials      607      609       +2     
Flag Coverage Ξ”
unittests 45.92% <53.96%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
actions/register.go 100.00% <100.00%> (ΓΈ)
actions/transactions/routes.go 100.00% <100.00%> (ΓΈ)
config/config.go 33.33% <ΓΈ> (ΓΈ)
engine/testabilities/fixture_configopts.go 100.00% <100.00%> (ΓΈ)
engine/testabilities/fixture_engine.go 90.26% <ΓΈ> (ΓΈ)
server/handlers/manager.go 100.00% <100.00%> (ΓΈ)
server/server.go 8.33% <100.00%> (ΓΈ)
engine/client.go 53.62% <0.00%> (-0.34%) ⬇️
config/config_to_options.go 0.00% <0.00%> (ΓΈ)
engine/client_internal.go 58.04% <81.25%> (-0.25%) ⬇️
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 1acad0e...adb4b66. Read the comment docs.

actions/contacts/routes.go Outdated Show resolved Hide resolved
Copy link
Contributor

@wregulski wregulski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! πŸ‘Œ

@chris-4chain chris-4chain added the regression-tests Runs regression tests label Dec 20, 2024
@wregulski wregulski added the tested PR was tested by a team member label Dec 20, 2024
@chris-4chain chris-4chain merged commit 24e038f into main Dec 20, 2024
24 of 25 checks passed
@chris-4chain chris-4chain deleted the feat/SPV-1300 branch December 20, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-tests Runs regression tests tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants