-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SPV-1295): testabilities for contacts admin #842
feat(SPV-1295): testabilities for contacts admin #842
Conversation
Manual Testsπ Manual testing by @dorzepowski resulted in success. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
- Coverage 46.18% 46.11% -0.07%
==========================================
Files 373 376 +3
Lines 17933 18014 +81
==========================================
+ Hits 8282 8307 +25
- Misses 9027 9086 +59
+ Partials 624 621 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job,
For me, it reads much better then the previous approach.
Pull Request Checklist