Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1295): testabilities for contacts admin #842

Merged
merged 12 commits into from
Jan 9, 2025

Conversation

dzolt-4chain
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@dzolt-4chain dzolt-4chain requested a review from a team as a code owner January 8, 2025 20:31
Copy link

github-actions bot commented Jan 8, 2025

Manual Tests

πŸ’š Manual testing by @dorzepowski resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.39535% with 16 lines in your changes missing coverage. Please review.

Project coverage is 46.11%. Comparing base (a4674ce) to head (453dd82).

Files with missing lines Patch % Lines
...ne/tester/paymailmock/mock_capability_factories.go 65.21% 6 Missing and 2 partials ⚠️
engine/action_contact.go 0.00% 3 Missing ⚠️
engine/contact/testabilities/assert_contact.go 92.10% 3 Missing ⚠️
engine/tester/paymailmock/mock_capability.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   46.18%   46.11%   -0.07%     
==========================================
  Files         373      376       +3     
  Lines       17933    18014      +81     
==========================================
+ Hits         8282     8307      +25     
- Misses       9027     9086      +59     
+ Partials      624      621       -3     
Flag Coverage Ξ”
unittests 46.11% <81.39%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
engine/contact/testabilities/ability_contact.go 100.00% <100.00%> (ΓΈ)
engine/contact/testabilities/fixture_contact.go 100.00% <100.00%> (ΓΈ)
engine/testabilities/fixture_engine.go 90.43% <100.00%> (+0.16%) ⬆️
engine/tester/fixtures/users_fixtures.go 26.56% <ΓΈ> (ΓΈ)
engine/tester/paymailmock/mock_capability.go 78.94% <71.42%> (+1.16%) ⬆️
engine/action_contact.go 27.80% <0.00%> (-9.85%) ⬇️
engine/contact/testabilities/assert_contact.go 92.10% <92.10%> (ΓΈ)
...ne/tester/paymailmock/mock_capability_factories.go 86.44% <65.21%> (-13.56%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update a4674ce...453dd82. Read the comment docs.

engine/contact/contact_test.go Outdated Show resolved Hide resolved
engine/contact/testabilities/assert_contact.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dorzepowski dorzepowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job,
For me, it reads much better then the previous approach.

engine/contact/contact_test.go Outdated Show resolved Hide resolved
engine/contact/contact_test.go Outdated Show resolved Hide resolved
engine/contact/contact_test.go Outdated Show resolved Hide resolved
engine/contact/contact_test.go Outdated Show resolved Hide resolved
engine/contact/contact_test.go Outdated Show resolved Hide resolved
engine/contact/testabilities/assert_contact.go Outdated Show resolved Hide resolved
engine/contact/contact_test.go Outdated Show resolved Hide resolved
engine/contact/contact_test.go Outdated Show resolved Hide resolved
engine/contact/contact_test.go Show resolved Hide resolved
engine/contact/contact_test.go Show resolved Hide resolved
engine/contact/contact_test.go Outdated Show resolved Hide resolved
engine/contact/testabilities/assert_contact.go Outdated Show resolved Hide resolved
engine/contact/testabilities/assert_contact.go Outdated Show resolved Hide resolved
engine/contact/testabilities/assert_contact.go Outdated Show resolved Hide resolved
engine/tester/fixtures/users_fixtures.go Outdated Show resolved Hide resolved
@dorzepowski dorzepowski added the tested PR was tested by a team member label Jan 9, 2025
@dzolt-4chain dzolt-4chain merged commit b3d25d9 into main Jan 9, 2025
13 checks passed
@dzolt-4chain dzolt-4chain deleted the feat/SPV-1295/testabilities-for-contacts-admin branch January 9, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants