Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SPV-1357): webhook tests #843

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Jan 9, 2025

Checked 4 times on GithubActions, and it works (one failed but because of other reason)
https://github.com/bitcoin-sv/spv-wallet/actions/runs/12685363196

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Copy link

github-actions bot commented Jan 9, 2025

Manual Tests

💚 Manual testing by @dzolt-4chain resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.27%. Comparing base (d8a633c) to head (8ad7d45).

Files with missing lines Patch % Lines
engine/notifications/webhook_manager.go 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
+ Coverage   46.16%   46.27%   +0.10%     
==========================================
  Files         373      373              
  Lines       17928    17933       +5     
==========================================
+ Hits         8277     8298      +21     
+ Misses       9027     9013      -14     
+ Partials      624      622       -2     
Flag Coverage Δ
unittests 46.27% <85.71%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
engine/notifications/webhook_manager.go 52.89% <85.71%> (+1.77%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a633c...8ad7d45. Read the comment docs.

@chris-4chain chris-4chain marked this pull request as ready for review January 9, 2025 07:46
@chris-4chain chris-4chain requested a review from a team as a code owner January 9, 2025 07:46
Copy link
Contributor

@dorzepowski dorzepowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

engine/notifications/webhook_manager.go Outdated Show resolved Hide resolved
engine/notifications/webhook_manager.go Show resolved Hide resolved
@dzolt-4chain dzolt-4chain added the tested PR was tested by a team member label Jan 9, 2025
@chris-4chain chris-4chain merged commit a4674ce into main Jan 9, 2025
13 checks passed
@chris-4chain chris-4chain deleted the fix/SPV-1357-webhook-tests branch January 9, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants