Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1393): remove old API #862

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Conversation

pawellewandowski98
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@pawellewandowski98 pawellewandowski98 self-assigned this Jan 21, 2025
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner January 21, 2025 14:39
Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 51.37%. Comparing base (8a72289) to head (57feb06).

Files with missing lines Patch % Lines
mappings/search.go 0.00% 8 Missing ⚠️
actions/access_keys/search.go 0.00% 2 Missing ⚠️
actions/access_keys/get.go 0.00% 1 Missing ⚠️
actions/access_keys/revoke.go 0.00% 1 Missing ⚠️
actions/contacts/search.go 0.00% 1 Missing ⚠️
actions/contacts/upsert.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
+ Coverage   46.88%   51.37%   +4.49%     
==========================================
  Files         406      377      -29     
  Lines       18932    16829    -2103     
==========================================
- Hits         8876     8646     -230     
+ Misses       9342     7492    -1850     
+ Partials      714      691      -23     
Flag Coverage Ξ”
unittests 51.37% <0.00%> (+4.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
actions/access_keys/create.go 0.00% <ΓΈ> (ΓΈ)
actions/access_keys/routes.go 100.00% <ΓΈ> (ΓΈ)
actions/admin/routes.go 100.00% <ΓΈ> (ΓΈ)
actions/admin/stats.go 50.00% <ΓΈ> (+25.00%) ⬆️
actions/admin/status.go 100.00% <ΓΈ> (+50.00%) ⬆️
actions/contacts/accept.go 0.00% <ΓΈ> (ΓΈ)
actions/contacts/confirm.go 0.00% <ΓΈ> (ΓΈ)
actions/contacts/reject.go 0.00% <ΓΈ> (ΓΈ)
actions/contacts/routes.go 100.00% <ΓΈ> (ΓΈ)
actions/contacts/unconfirm.go 0.00% <ΓΈ> (ΓΈ)
... and 34 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 8a72289...57feb06. Read the comment docs.

mappings/paymail_address_old.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dorzepowski dorzepowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job,
I'm waiting for removing all the garbage that was mentioned by @dzolt-4chain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants