Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP78: Allow mixed inputs and clarify a few things #1244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Dec 2, 2021

  1. BIP78: Allow mixed inputs and clarify a few things

    Disallowing mixed inputs was based on incorrect assumption that no
    wallet supports mixed inputs and thus mixed inputs imply PayJoin.
    However there are at least three wallets supporting mixed inputs.
    (Confirmed: Bitcoin Core, LND, Coinomi; I think I remember seeing
    Samourai doing mixed inputs too.) Thus it makes sense to enable mixed
    inputs. To avoid compatibility issues a grace period is suggested.
    
    Additional clarifications were made:
    * Disallow reciever removing output - such would break the reference
      implementation and seems better than changing the reference
      implementation.
    * Forbid sender changing TXID in special case where no input is added.
    * Confirm that `amount` is *not* mandatory.
    Kixunil committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    d4e69ca View commit details
    Browse the repository at this point in the history