Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup README table #1438

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Cleanup README table #1438

merged 4 commits into from
Mar 29, 2023

Conversation

ajtowns
Copy link
Contributor

@ajtowns ajtowns commented Mar 27, 2023

Cleans up the README table, particularly after merge of bip 327.

@kallewoof
Copy link
Contributor

Thanks. I don't think this needs ACKs from authors except maybe for the BIP-327 change:

  • BIP-326 title fix aligns with the BIP itself
  • BIP-157 fix reflects the actual status of the BIP
  • BIP-327 fix makes slight alternation to title to fit width max, but the change is trivial and does not change the meaning in any way

@ajtowns
Copy link
Contributor Author

ajtowns commented Mar 28, 2023

cc @jonasnick @real-or-random @robot-dreams for BIP-327 title tweak (replace "for" with ":")

@real-or-random
Copy link
Contributor

cc @jonasnick @real-or-random @robot-dreams for BIP-327 title tweak (replace "for" with ":")

To be honest, I prefer the "for". We'll come back to you, maybe there's another way to get it down one char.

@ajtowns
Copy link
Contributor Author

ajtowns commented Mar 28, 2023

To be honest, I prefer the "for". We'll come back to you, maybe there's another way to get it down one char.

Could change "multi-signature" to "multisignature" throughout the bip, matching bip340's spelling? EDIT: I guess that diverges from the paper's spelling which would be annoying. Could just drop the "-compatible" entirely?

@jonasnick
Copy link
Contributor

BIP-327 fix makes slight alternation to title to fit width max, but the change is trivial and does not change the meaning in any way

Is it not possible to adjust the width max? The table in master looks fine at first glance (in my browser).

@kallewoof
Copy link
Contributor

Yes, that's a possible solution too. I'm not sure why it was set to this specific value, though.

@ajtowns
Copy link
Contributor Author

ajtowns commented Mar 29, 2023

Added 327 to the title length exceptions list, so that CI can go back to passing without needing to wait for an extended debate about titles...

@kallewoof kallewoof merged commit b3144df into bitcoin:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants