bip93: minor cleanups #1439
Merged
bip93: minor cleanups #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These examples are valid BIP-173 and BIP-350 strings (but not valid BIP-93 strings).
|
So, strictly speaking, a BIP change needs to be approved by an author, but seeing as you were the one who originally posted the BIP, this seems like a silly requirement to make here. It would be great if you added yourself to the authors list along with this change, so we don't have to try to find people who aren't even on github to approve of changes. |
|
@kallewoof sure, I've added myself as an author. I think this is probably fine since I did PR the original BIP text, but if you'd like I can get Pearlwort to send you (or somebody) an email. |
apoelstra
force-pushed
the
2023-03--bip93-cleanup
branch
from
3ec44b2 to
bd1ea9c
Compare
I think it doesn't like the and? |
apoelstra
force-pushed
the
2023-03--bip93-cleanup
branch
from
bd1ea9c to
966274e
Compare
apoelstra
force-pushed
the
2023-03--bip93-cleanup
branch
from
966274e to
c02efd1
Compare
|
I think it's about having multiple email addresses on one line. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new test vectors, but otherwise purely corrects grammar/syntax mistakes and makes no changes to the BIP content.