BIP93: correct threshold range #2023
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
changed the title
jonatack
reviewed
Nov 4, 2025
| It includes an encoding format, a BCH error-correcting checksum, and algorithms for share generation and secret recovery. | ||
| Secret data can be split into up to 31 shares. | ||
| A minimum threshold of shares, which can be between 1 and 9, is needed to recover the secret, whereas without sufficient shares, no information about the secret is recoverable. | ||
| A minimum threshold of shares, which can be 0 (for unshared secret) or between 2 and 9 (for shares), is needed to recover the secret, whereas without sufficient shares, no information about the secret is recoverable. |
There was a problem hiding this comment.
Not sure about this change.
The current abstract states "between 1 and 9" for what "is needed to recover the secret".
And the Recovering Master Seed section stipulates: "The first character of the data part indicates the threshold of the share, and it is required to be a non-"0" digit."
So these two excerpts seem to concur? Perhaps it could be clearer.
cc @apoelstra for feedback
jonatack
added
Proposed BIP modification
Pending acceptance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Abstract to align with specification: threshold can be 0 for unshared secret or 2-9 for shares.
Apparently previous "between 1 and 9" range appears inconsistent with the detailed spec (threshold=1 isn't valid in codex32).