[tests] mining functional tests (including regression test for submitblock) #10190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmysong
reviewed
Apr 18, 2017
Contributor
jimmysong
left a comment
jimmysong
left a comment
There was a problem hiding this comment.
utACK df93f6cc8d80e78eb8758a7d6b5148df9bc3afa9
Gets rid of a lot of duplicate logic. A few nits.
test/functional/mining.py
Outdated
Contributor
There was a problem hiding this comment.
Guessing you'll want to change this comment.
Contributor
There was a problem hiding this comment.
is tmpl['transactions'] expected to be empty?
test/functional/mining.py
Outdated
Contributor
There was a problem hiding this comment.
rename the test to MiningTest?
test/functional/mining.py
Outdated
jimmysong
approved these changes
Apr 18, 2017
Contributor
jimmysong
left a comment
jimmysong
left a comment
There was a problem hiding this comment.
ACK 8d80db230b3a07680cec1c227ff84dbe0678cf45
jnewbery
force-pushed
the
mining_functional_test
branch
from
8d80db2 to
8b8859b
Compare
Contributor
Author
Contributor
|
Concept ACK. I am testing the test. |
Contributor
Author
|
No great rush for this but it'd be good to get it in soonish. It includes a regression test for #10146, which was backported to 0.14.1. Other benefits:
|
jnewbery
force-pushed
the
mining_functional_test
branch
from
8b8859b to
11ba8e9
Compare
Contributor
Author
|
rebased |
jnewbery
changed the title
Member
|
utACK 11ba8e9 |
laanwj
added a commit
that referenced
this pull request
Jul 11, 2017
…est for submitblock) 11ba8e9 [tests] rename getblocktemplate_proposals.py to mining.py (John Newbery) b29dd41 [tests] add test for submit block (John Newbery) 9bf0d80 [tests] run successful test in getblocktemplate first (John Newbery) 82dc597 [tests] don't build blocks manually in getblocktemplate test (John Newbery) f82c709 [tests] clarify assertions in getblocktemplate test (John Newbery) 66c570a [tests] Don't build the coinbase manually in getblocktemplate test (John Newbery) 38b38cd [tests] getblocktemplate_proposals.py: add logging (John Newbery) 0a3a5ff [tests] Fix flake8 warnings in getblocktemplate tests (John Newbery) 32cffe6 [tests] Fix import order in getblocktemplate test (John Newbery) Tree-SHA512: a51a57314fa1c4c4b8a7896492ec6e677b6bed12387060def34a62e9dfbee7961f71bb5553fbd70028be61ae32eccf13fd255fa9651f908e9a5e64c28f43f00e
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 18, 2019
…ssion test for submitblock) 11ba8e9 [tests] rename getblocktemplate_proposals.py to mining.py (John Newbery) b29dd41 [tests] add test for submit block (John Newbery) 9bf0d80 [tests] run successful test in getblocktemplate first (John Newbery) 82dc597 [tests] don't build blocks manually in getblocktemplate test (John Newbery) f82c709 [tests] clarify assertions in getblocktemplate test (John Newbery) 66c570a [tests] Don't build the coinbase manually in getblocktemplate test (John Newbery) 38b38cd [tests] getblocktemplate_proposals.py: add logging (John Newbery) 0a3a5ff [tests] Fix flake8 warnings in getblocktemplate tests (John Newbery) 32cffe6 [tests] Fix import order in getblocktemplate test (John Newbery) Tree-SHA512: a51a57314fa1c4c4b8a7896492ec6e677b6bed12387060def34a62e9dfbee7961f71bb5553fbd70028be61ae32eccf13fd255fa9651f908e9a5e64c28f43f00e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the getblocktemplate_proposals.py functional test into a more general mining test, which covers the
submitblockRPC as well as thegetblocktemplatepropose mode.Motivation was to add a regression test for #10146
This test removes all the manual block/transaction construction from the test case and uses the mininode classes to achieve the same tests. Result is less lines of code, and hopefully clearer and easier for people to extend/maintain since we're no longer hacking bits in a serialised block.
@gmaxwell since he wrote the fix for #10146
EDIT: there are lots of commits in this PR to aid reviewers. They can be squashed down into larger commits before merging.