Avoid redundant redeclaration of GetWarnings(const string&) #10864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Jul 18, 2017
src/validation.h
Outdated
Contributor
Author
There was a problem hiding this comment.
Fixed! Thanks!
std::string GetWarnings(const std::string& strFor) is declared in warnings.h and defined in warnings.cpp.
practicalswift
force-pushed
the
GetWarnings-in-warnings.h
branch
from
3a46c35 to
e0d4592
Compare
Contributor
|
utACK e0d4592 |
Member
|
utACK e0d4592 |
Member
|
utACK e0d4592 |
Contributor
|
utACK e0d4592 |
jonasschnelli
added a commit
that referenced
this pull request
Jul 19, 2017
…ng&) e0d4592 Avoid redundant redeclaration of GetWarnings(const string&) (practicalswift) Pull request description: Avoid redundant redeclaration of `GetWarnings(const string&)`. `std::string GetWarnings(const std::string& strFor)` is declared in `warnings.h` and defined in `warnings.cpp`. Tree-SHA512: d1503e00a2073cf080d66eafa303dc9c660a7ac15d4d2abcf2e4aa69cf9622d89a8e3f09324139bb7b8debaa6d1ee4a1c1681d347cebd99b1d3672a4da6d1ace
Contributor
|
Sorry. I accidentally merged this after the freeze. |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 24, 2019
…st string&) e0d4592 Avoid redundant redeclaration of GetWarnings(const string&) (practicalswift) Pull request description: Avoid redundant redeclaration of `GetWarnings(const string&)`. `std::string GetWarnings(const std::string& strFor)` is declared in `warnings.h` and defined in `warnings.cpp`. Tree-SHA512: d1503e00a2073cf080d66eafa303dc9c660a7ac15d4d2abcf2e4aa69cf9622d89a8e3f09324139bb7b8debaa6d1ee4a1c1681d347cebd99b1d3672a4da6d1ace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid redundant redeclaration of
GetWarnings(const string&).std::string GetWarnings(const std::string& strFor)is declared inwarnings.hand defined inwarnings.cpp.