Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GetStartOnSystemStartup and SetStartOnSystemStartup to GUI code #1178

Merged
merged 1 commit into from
May 13, 2012

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented May 1, 2012

...as this is the logical place for them.

@Diapolo can you test whether this still builds on windows? I'm not sure what includes are needed for CoCreateInstance / GetModuleFileName.

@Diapolo
Copy link

Diapolo commented May 1, 2012

Sure, will report back after I did the tests :).

@@ -17,6 +18,9 @@
#include <QDesktopServices>
#include <QThread>

#include <boost/filesystem.hpp>
#include <boost/filesystem/fstream.hpp>

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs:

#ifdef WIN32
#include "shlwapi.h"
#endif

@Diapolo
Copy link

Diapolo commented May 1, 2012

Seems like a good idea to move MyGetSpecialFolderPath function from util.cpp into guiutil.cpp, too, as I currently get: guiutil.cpp:229: Fehler:'MyGetSpecialFolderPath' was not declared in this scope.

@Diapolo
Copy link

Diapolo commented May 1, 2012

It seems that shlwapi.h can be removed from util.cpp after your changes.

@laanwj
Copy link
Member Author

laanwj commented May 1, 2012

Thanks for the fixes.

MyGetSpecialFolderPath cannot be moved as it's also used in GetDefaultDataDir, which should certainly stay in the core code.

On the other hand, if we can remove the fallbacks, we could simply use the windows API function SHGetSpecialFolderPathA directly in both places and get rid of MyGetSpecialFolderPath. For now, I'll simply add it to util.h.

@laanwj
Copy link
Member Author

laanwj commented May 1, 2012

Ok, updated.

@Diapolo
Copy link

Diapolo commented May 1, 2012

Now compiles fine on Windows, just see above comment for guiutil.cpp :). I will have to rebase #1134 after this get's merged, but that's fine. I consider removing MyGetSpecialFolderPath() then.

@laanwj
Copy link
Member Author

laanwj commented May 5, 2012

Updated to _WIN32_IE 0x0501

@laanwj
Copy link
Member Author

laanwj commented May 13, 2012

Rebased

laanwj added a commit that referenced this pull request May 13, 2012
Move GetStartOnSystemStartup and SetStartOnSystemStartup to GUI code
@laanwj laanwj merged commit b07ea7c into bitcoin:master May 13, 2012
coblee pushed a commit to litecoin-project/litecoin that referenced this pull request Jul 17, 2012
…mstartup

Move GetStartOnSystemStartup and SetStartOnSystemStartup to GUI code
@laanwj laanwj deleted the 2012_05_move_startonsystemstartup branch April 9, 2014 14:15
suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this pull request Dec 5, 2017
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Jan 22, 2019
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Dec 25, 2019
…ve addresses list.

6ee4e57 [GUI][Bug] cold staking screen, fixing show receive addresses list in owner address editLine. (furszy)

Pull request description:

  It was invalidly blocking the launch of the dropdown menu for a bad check. Instead of the receive addresses (`sizeRecv()`), was checking against the stored contacts in the address book (`sizeSend()`) .

ACKs for top commit:
  Fuzzbawls:
    utACK 6ee4e57
  random-zebra:
    utACK 6ee4e57 and merging...

Tree-SHA512: 3a4bf346079e35baaf5f66379e303cdfdffef662c099c967f421cc309f82b514bde4c716ad5df5c669164b82d533663ebf11d9af75b468143f6d52b802854da9
Bushstar added a commit to Bushstar/omnicore that referenced this pull request Oct 21, 2020
Add new transaction type to embed any data
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants