doc: Update init and reduce-traffic docs for -blocksonly #18391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Mar 20, 2020
There was a problem hiding this comment.
- The walletbroadcast is only set "softly" to
0, i.e. when it was not set otherwise (in the config or on the command line) - RPC transactions are relayed as far as I can tell, see also the second section in the test
./test/functional/p2p_blocksonly.py - It would be nice to extend that test for wallet transactions and maybe even whitelisted peers. (Not necessarily in this pull, it can also be done later)
|
Lines |
Are you referring to “wallet transaction" as a loose term? I thought wallet transaction includes the ones initiated via rpc already? @MarcoFalke I would love to add more tests as you mentioned in a follow up PR! |
glowang
force-pushed
the
update_blocksonly_docs
branch
4 times, most recently
from
be1b3b9
to
9a7d39b
Compare
maflcko
reviewed
Mar 25, 2020
andrewtoth
reviewed
Mar 25, 2020
laanwj
reviewed
Mar 25, 2020
|
Thanks for improving the documentation! |
glowang
force-pushed
the
update_blocksonly_docs
branch
from
9a7d39b
to
869327c
Compare
|
ACK 869327c |
maflcko
reviewed
Mar 27, 2020
glowang
force-pushed
the
update_blocksonly_docs
branch
4 times, most recently
from
92255ae
to
b4a976d
Compare
maflcko
approved these changes
Mar 29, 2020
src/net.h
Outdated
| @@ -64,7 +64,7 @@ static const unsigned int MAX_SUBVERSION_LENGTH = 256; | |||
| /** Maximum number of automatic outgoing nodes over which we'll relay everything (blocks, tx, addrs, etc) */ | |||
| static const int MAX_OUTBOUND_FULL_RELAY_CONNECTIONS = 8; | |||
| /** Maximum number of addnode outgoing nodes */ | |||
| static const int MAX_ADDNODE_CONNECTIONS = 8; | |||
| static const int MAX_ADDNODE_CONNECTIONS = 10; | |||
There was a problem hiding this comment.
Code changes (behaviour changes) should probably be in a separate pull request from documentation changes.
When -blocksonly is set to 1, it interacts with the -walletbroadcast parameter and sets it to 0 if it has not been set already.This behavior is not captured by the current documentation, which claims that -blocksonly does not impact any wallet transactions. Update the max number of outgoing peers from 8 to 10, due to the addition of two -blocksonly peers.
glowang
force-pushed
the
update_blocksonly_docs
branch
from
b4a976d
to
621e86e
Compare
|
ACK 621e86e |
maflcko
reviewed
Mar 29, 2020
| @@ -24,8 +24,7 @@ The size of some in-memory caches can be reduced. As caches trade off memory usa | |||
|
|
|||
| ## Number of peers | |||
|
|
|||
| - `-maxconnections=<n>` - the maximum number of connections, this defaults to `125`. Each active connection takes up some memory. Only significant if incoming | |||
| connections are enabled, otherwise the number of connections will never be more than `8`. | |||
| - `-maxconnections=<n>` - the maximum number of connections, this defaults to `125`. Each active connection takes up some memory. Only significant if incoming connections are enabled, otherwise the number of connections will never be more than `10`. Of the 10 outbound peers, there can be 8 full outgoing connections and 2 -blocksonly peers, in which case they are block/addr peers, but not tx peers. | |||
There was a problem hiding this comment.
whoopsie, just realized that blocksonly is different from block-relay-only. Fixed in #18464
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 14, 2021
Summary: > When -blocksonly is set to 1, it interacts with the -walletbroadcast > parameter and sets it to 0 if it has not been set already.This behavior > is not captured by the current documentation, which claims that -blocksonly > does not impact any wallet transactions. > > Update the max number of outgoing peers from 8 to 10, due to the > addition of two -blocksonly peers. This is a backport of Core [[bitcoin/bitcoin#18391 | PR18391]] and [[bitcoin/bitcoin#18464 | PR18464]] Test Plan: `ninja && src/bitcoind -help` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D8894
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 31, 2021
Add -blocksonly option Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6993 - bitcoin/bitcoin#7046 - bitcoin/bitcoin#6780 - The third commit (we backported the rest in #2390). - bitcoin/bitcoin#7126 - bitcoin/bitcoin#7439 - bitcoin/bitcoin#15990 - Only the `-blocksonly` documentation changes. - bitcoin/bitcoin#16555 - bitcoin/bitcoin#18391 - Only the `-blocksonly` documentation changes. Part of #2074.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When -blocksonly is set to 1, it interacts with the -walletbroadcast
parameter and sets it to 0.
This behavior is not captured by the current documentation, which
claims that -blocksonly does not impact any wallet transactions at
all.
Fixes #17294