Remove utxo db upgrade code #24236
Remove utxo db upgrade code #24236
Conversation
maflcko
force-pushed
the
2202-txdbNoUpgrade
branch
from
16e2a31 to
fa96982
Compare
|
Concept ACK |
1 similar comment
|
Concept ACK |
maflcko
force-pushed
the
2202-txdbNoUpgrade
branch
4 times, most recently
from
fafd3a6 to
faf989d
Compare
There was a problem hiding this comment.
Concept ACK. Prefer to merge this after the v23 branch-off, unless anything builds on it.
tACK faf989d08a5ae914cb8510a4edd49dd9ed076086
In the release notes we could suggest that users who are still on v0.13.1-0.14.x can, as an alternative to reindexing, first upgrade to v22.0.
There is a bunch of stuff that builds on it, but no rush. Assigned 24.0 for now. |
maflcko
force-pushed
the
2202-txdbNoUpgrade
branch
from
faf989d to
fa97554
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
maflcko
force-pushed
the
2202-txdbNoUpgrade
branch
from
fa97554 to
fa39235
Compare
maflcko
force-pushed
the
2202-txdbNoUpgrade
branch
from
fa39235 to
fabd801
Compare
otech47
left a comment
otech47
left a comment
There was a problem hiding this comment.
LGTM
any rationale for testing against v0.14.3 versus v0.13.1? or both?
Thanks for the review. 13.x can not be tested by our current test framework, as there were changes in 14.x that were backward compatible, but not forward compatible. See https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.14.0.md#support-for-json-rpc-named-arguments It is possible to adjust the test framework for this to test 13.x, but I don't think this is worth it. The automated test with 14.x should be sufficient. Also, anyone can run a test with 13.x locally for a one-off. |
maflcko
force-pushed
the
2202-txdbNoUpgrade
branch
from
fabd801 to
fa9112a
Compare
|
Addressed test nit. Should be trivial to re-ACK with: |
|
re-ACK fa9112a |
|
Code review ACK fa9112a |
6 participants
It is not possible to upgrade Bitcoin Core pre-segwit (pre-0.13.1) to a recent version without a full IBD from scratch after commit 19a56d1 (released in version 22.0).
Any Bitcoin Core version with the new database format after commit 1088b02 (released in version 0.15), can upgrade to any version that is supported as of today.
This leaves the versions 0.13.1-0.14.x. Even though those versions are unsupported, some users with an existing datadir may want to upgrade to a recent version. However, it seems reasonable to simply ask them to
-reindexto run a full IBD from scratch. This allows us to remove the utxo db upgrade code.