test: remove unused CHANGE_{XPRV,XPUB} constants
#26437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These constants exist since the introduction of the functional test wallet_taproot.py (2667366), but they have never been used.
Member
|
ACK f1ee974 |
maflcko
pushed a commit
that referenced
this pull request
Nov 1, 2022
f1ee974 test: remove unused `CHANGE_{XPRV,XPUB}` constants (Sebastian Falbesoner) Pull request description: These constants exist since the introduction of the functional test wallet_taproot.py (2667366), but they have never been used. ACKs for top commit: instagibbs: ACK f1ee974 brunoerg: ACK f1ee974 Tree-SHA512: 2c6f8cd537c35af59c4cbe6abb07386b7fb9e4662c7bed27ad8935e004f9bf452705fb1caef4f5ea1f4ad509745afba966005f95a18cf2b59e00b7739a5df7f8
Member
|
This has been merged. |
theStack
deleted the
202211-test-remove_unused_change_xprv_xpub_constants
branch
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 1, 2022
f1ee974 test: remove unused `CHANGE_{XPRV,XPUB}` constants (Sebastian Falbesoner) Pull request description: These constants exist since the introduction of the functional test wallet_taproot.py (2667366), but they have never been used. ACKs for top commit: instagibbs: ACK f1ee974 brunoerg: ACK f1ee974 Tree-SHA512: 2c6f8cd537c35af59c4cbe6abb07386b7fb9e4662c7bed27ad8935e004f9bf452705fb1caef4f5ea1f4ad509745afba966005f95a18cf2b59e00b7739a5df7f8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constants exist since the introduction of the functional test wallet_taproot.py (2667366), but they have never been used.