guix: update signapple to latest master #28759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK. |
Reducing the bootstrapping footprint is great. concept ACK. |
fanquake
force-pushed
the
update_signapple_norust_bootstrap
branch
from
899ed91 to
79539fb
Compare
|
Concept ACK. |
|
Guix Build (aarch64): 66c24a02462fa98aa772a7347bfa5edd64f79979e256b463cdc82808a74dc38e guix-build-79539fbfbf4d/output/aarch64-linux-gnu/SHA256SUMS.part
bf0e04a6dfc8d580428c8e33eedb57f2ec311eff054387dac985abc1e2c50a3a guix-build-79539fbfbf4d/output/aarch64-linux-gnu/bitcoin-79539fbfbf4d-aarch64-linux-gnu-debug.tar.gz
4e9d47a41bfd12f3aa5bb553b162a348359b289a4d1eeb0ce83029852bf66036 guix-build-79539fbfbf4d/output/aarch64-linux-gnu/bitcoin-79539fbfbf4d-aarch64-linux-gnu.tar.gz
e912a655d033eb003f21b87a915106805446f821cdb76054319a7faa27414fb8 guix-build-79539fbfbf4d/output/arm-linux-gnueabihf/SHA256SUMS.part
9011963ba8bb4031f70e2e0aa61bf83c541a214b1a2c16c7af028a1c6cce7b46 guix-build-79539fbfbf4d/output/arm-linux-gnueabihf/bitcoin-79539fbfbf4d-arm-linux-gnueabihf-debug.tar.gz
9f5517fe519f401c4f5c56ca803757e88fde39592b0953f2ba629b29a0e62822 guix-build-79539fbfbf4d/output/arm-linux-gnueabihf/bitcoin-79539fbfbf4d-arm-linux-gnueabihf.tar.gz
5ea366688e718b729dcdc9905ceb6a70fd450ee620a86fe3a2e2bf5e4a3db6ab guix-build-79539fbfbf4d/output/arm64-apple-darwin/SHA256SUMS.part
92ec16c059494878935b58536d34388c0e6a8fda8a88e2f794e369b31e509004 guix-build-79539fbfbf4d/output/arm64-apple-darwin/bitcoin-79539fbfbf4d-arm64-apple-darwin-unsigned.tar.gz
fc73e7e4fa24a2777a4c01980eb3b8136990073232aa929bbb20080a546b37a2 guix-build-79539fbfbf4d/output/arm64-apple-darwin/bitcoin-79539fbfbf4d-arm64-apple-darwin-unsigned.zip
35fd97bef578b0843e11e91a1d0e7c5121768e6659fc69cd32be558196bed81d guix-build-79539fbfbf4d/output/arm64-apple-darwin/bitcoin-79539fbfbf4d-arm64-apple-darwin.tar.gz
c725d9cff5d6898c144deb6d302655211e7069a55cd103968212785c73f2065a guix-build-79539fbfbf4d/output/dist-archive/bitcoin-79539fbfbf4d.tar.gz
559f9e373ea4adaf59422ca9e9546e7661d86aa5cb793aac71cebb080c6a23c3 guix-build-79539fbfbf4d/output/powerpc64-linux-gnu/SHA256SUMS.part
38b93171d4542a25c3974604030352ad73eb053304681542599fee0d3fa29a4e guix-build-79539fbfbf4d/output/powerpc64-linux-gnu/bitcoin-79539fbfbf4d-powerpc64-linux-gnu-debug.tar.gz
4cd8da21bb9831cdb8d3bf359d6eb41a67f9a57b213375900ae127bd4b053aa2 guix-build-79539fbfbf4d/output/powerpc64-linux-gnu/bitcoin-79539fbfbf4d-powerpc64-linux-gnu.tar.gz
aa2fc1295460b1886fbacb23083d8204d708f25739f573a20eab8f7374defa21 guix-build-79539fbfbf4d/output/powerpc64le-linux-gnu/SHA256SUMS.part
549650d52b3d6be0d001fbca419eaf9ba87be7fe59de1e1509b169d18f33327b guix-build-79539fbfbf4d/output/powerpc64le-linux-gnu/bitcoin-79539fbfbf4d-powerpc64le-linux-gnu-debug.tar.gz
95d83d7a418f3b9d67d45e57d282ceda65a7646407b3bf71801e6ca414fa48c9 guix-build-79539fbfbf4d/output/powerpc64le-linux-gnu/bitcoin-79539fbfbf4d-powerpc64le-linux-gnu.tar.gz
a96ee13a6b0cf91ca891d1577ead2d4662c9297d6f82f03d69da72ab04f31721 guix-build-79539fbfbf4d/output/riscv64-linux-gnu/SHA256SUMS.part
4d878e16999b4d36638630740b25c18a7ffdaf9329003846297ab278b7b5209b guix-build-79539fbfbf4d/output/riscv64-linux-gnu/bitcoin-79539fbfbf4d-riscv64-linux-gnu-debug.tar.gz
5cd87541a02f2319bd31dcba29e51e716362b803111f04d716af6e50694b01cf guix-build-79539fbfbf4d/output/riscv64-linux-gnu/bitcoin-79539fbfbf4d-riscv64-linux-gnu.tar.gz
f127dc1444ae23755d2cb4729d995669c5473e7933f5c16e094425218c7cf50a guix-build-79539fbfbf4d/output/x86_64-apple-darwin/SHA256SUMS.part
52f9083d8ca9bed5d660efc16b56c55eca6b62eccd91ac9ce467e3b3dfb89070 guix-build-79539fbfbf4d/output/x86_64-apple-darwin/bitcoin-79539fbfbf4d-x86_64-apple-darwin-unsigned.tar.gz
beeec3710916ee69af502853633b3fa1b626a7216f9990fcab8a3d4b18c9d036 guix-build-79539fbfbf4d/output/x86_64-apple-darwin/bitcoin-79539fbfbf4d-x86_64-apple-darwin-unsigned.zip
ffa4bfdb3a7f01af30b70abca8851743f0e6f50cb40e8370ff413304b5e1ae43 guix-build-79539fbfbf4d/output/x86_64-apple-darwin/bitcoin-79539fbfbf4d-x86_64-apple-darwin.tar.gz
e9464eeedb6ad6063f418ef111268108af4e8a19e451ae5f003c4c73ce275a68 guix-build-79539fbfbf4d/output/x86_64-linux-gnu/SHA256SUMS.part
747d76fea9a7eb954b046013f2ec3bffeee2744c38b08ece2ce2a21dfe72fa10 guix-build-79539fbfbf4d/output/x86_64-linux-gnu/bitcoin-79539fbfbf4d-x86_64-linux-gnu-debug.tar.gz
c4cc213133bdb5f30b70464f229985186827968caa83d0559b6bd99abeb43d48 guix-build-79539fbfbf4d/output/x86_64-linux-gnu/bitcoin-79539fbfbf4d-x86_64-linux-gnu.tar.gz
4c74a51e65bb9413bb8ce0e01330c4a1c5d5a058644d139826310aef39caeddd guix-build-79539fbfbf4d/output/x86_64-w64-mingw32/SHA256SUMS.part
6cd37121ba0a8d4c01adb2ba7f87fc9cd62ad4d3b62b39ca026074c1ec28d81f guix-build-79539fbfbf4d/output/x86_64-w64-mingw32/bitcoin-79539fbfbf4d-win64-debug.zip
ccb1f4b0da302500832a3cb1aa449f28596c15020456d48fe0d03ba6508aaac2 guix-build-79539fbfbf4d/output/x86_64-w64-mingw32/bitcoin-79539fbfbf4d-win64-setup-unsigned.exe
e39de2108b37e3d817c5e24d59c24c1531e281adc437fe29e5c9fa993ba7731b guix-build-79539fbfbf4d/output/x86_64-w64-mingw32/bitcoin-79539fbfbf4d-win64-unsigned.tar.gz
58104f17ae951e0c72aed5fa413c305807c09bb7dd293724f57c26ff70553eb0 guix-build-79539fbfbf4d/output/x86_64-w64-mingw32/bitcoin-79539fbfbf4d-win64.zip |
|
ACK 79539fb |
|
Added to #28754 for backporting to 26.x. |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Oct 31, 2023
Fixes bitcoin#28449 Github-Pull: bitcoin#28759 Rebased-From: 79539fb
fanquake
added a commit
that referenced
this pull request
Nov 1, 2023
e4e8479 doc: update manual pages for v26.0rc2 (fanquake) 0b189a9 build: bump version to v26.0rc2 (fanquake) e097d4c gui: fix crash on selecting "Mask values" in transaction view (Sebastian Falbesoner) 05e8874 guix: update signapple (fanquake) deccc50 guix: Zip needs to include all files with time as SOURCE_DATE_EPOCH (Andrew Chow) fe57abd test: add coverage for snapshot chainstate not matching AssumeUTXO parameters (pablomartin4btc) b761a58 assumeutxo, blockstorage: prevent core dump on invalid hash (pablomartin4btc) d3ebf6e [test] Test i2p private key constraints (Vasil Dimov) 1f11784 [net] Check i2p private key constraints (dergoegge) 6544ffa bugfix: Mark CNoDestination and PubKeyDestination constructor explicit (MarcoFalke) Pull request description: Backports for v26.0rc2: * #28695 * #28698 * #28728 * #28757 * #28759 * bitcoin-core/gui#774 ACKs for top commit: josibake: ACK e4e8479 hebasto: re-ACK e4e8479, only a backport of bitcoin-core/gui#774 added since my [recent](#28754 (review)) review. TheCharlatan: Re-ACK e4e8479 Tree-SHA512: 4b95afd26b8bf91250cb883423de8b274cefa48dc474734f5900aeb756eee3a6c656116efcfa2caff3c250678c16b70cc6b7a5d840018dc7e2c1e8161622cd61
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28449, and removes the need to boostrap Rust, by avoiding the
python-requestsdependency.Comparing a
--no-substitutesbuild of this PR, to master, signapple requires ~1350 less packages to boostrap:Master derivation - https://gist.github.com/fanquake/dbf69a62c9a78b7ae8c183a160e6d58d
PR derivation - https://gist.github.com/fanquake/0aa2d8eddaba861ba489ed3d936f727d