build: Drop no longer needed MSVC warning suppressions #28798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
lgtm ACK 33223f9 |
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Nov 7, 2023
816fd3b fixup! cmake: Add platform-specific definitions and properties (Hennadii Stepanov) e26415b fixup! cmake: Build `secp256k1` static library (Hennadii Stepanov) 077a534 fixup! cmake: Build `minisketch` static library (Hennadii Stepanov) 2a17419 fixup! cmake: Build `leveldb` static library (Hennadii Stepanov) Pull request description: This PR follows the master branch approach and amends the previous commits. Subtrees are treated separately from our code. Also please refer to: - https://github.com/hebasto/bitcoin/blob/953d302a242381ae13112ea42f87d57e6e796147/build_msvc/libleveldb/libleveldb.vcxproj#L54 - https://github.com/hebasto/bitcoin/blob/953d302a242381ae13112ea42f87d57e6e796147/build_msvc/libminisketch/libminisketch.vcxproj#L31 - https://github.com/hebasto/bitcoin/blob/953d302a242381ae13112ea42f87d57e6e796147/build_msvc/libsecp256k1/libsecp256k1.vcxproj#L20 - https://github.com/hebasto/bitcoin/blob/953d302a242381ae13112ea42f87d57e6e796147/build_msvc/common.init.vcxproj.in#L91-L93 - and bitcoin#28798 All warning suppressions are documented, ACKs for top commit: TheCharlatan: lgtm ACK 816fd3b Tree-SHA512: bfb5f44629312f1aefe97ec1508dc56fe54efb7b35ecc865eb735f3569367d527589a25585b19f5a42b45c66cc46ed65c0b8f6ce6bcca9addd9321b6110fbfb6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.