Fixed miner test values, gave constants for less error-prone values. #7807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Doing this I noticed yet another mis-typed value on https://github.com/bitcoin/bitcoin/pull/7807/files#diff-5c64500485fda76388a86c95c0059585L173 , so it seemed worthwhile. |
Member
|
That's clearer. Concept ACK 11679ca |
Member
|
utACK |
1 similar comment
Contributor
|
utACK |
src/test/miner_tests.cpp
Outdated
Contributor
|
As you are not replacing constants only, can you please change it so that you first replace constants unchanged and then do the changes, ie two commits? It will make review much easier... |
Member
Author
|
@paveljanik done |
Contributor
|
@instagibbs Reading this thoroughly, I think we could also define constants in the term of COIN and CENT, it could be even more descriptive. |
maflcko
pushed a commit
that referenced
this pull request
Apr 29, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in #7784 I decided to do a bit more cleanup.