Improve AlreadyHave #7874
Merged
Improve AlreadyHave #7874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
utACK c6cb6f7 |
Member
|
utACK c6cb6f7 |
Contributor
|
utACK c6cb6f7 |
Member
|
utACK c6cb6f7 |
laanwj
added a commit
that referenced
this pull request
Apr 14, 2016
c6cb6f7 Avoid unnecessary database access for unknown transactions (Alex Morcos)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Oct 19, 2017
c6cb6f7 Avoid unnecessary database access for unknown transactions (Alex Morcos)
1 task
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Aug 13, 2020
1ba085e Avoid unnecessary database access for unknown transactions (Alex Morcos) Pull request description: Based on top of: - [x] #1799 Only last commit is new. Now that we have implemented `HaveCoinsInCache`, we can use it to speed up `AlreadyHave`, by avoiding unnecessary database access for unknown transactions. (backported from bitcoin#7874) ACKs for top commit: Fuzzbawls: utACK 1ba085e furszy: utACK 1ba085e Tree-SHA512: f17c19b1ab00bac7bcf87fcfc513cfc7d2a690474a38bce6a9b9ba3c86ec5c4e064eb8a937e7cfdc8ef87d13e4b970d7de1be9a5957af19f2fa33c71286765b6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AlreadyHaveis called for transactions in 3 places:In a large number of these cases, the transaction in question is new and fails each of the tests in the return statement. In particular it is very unlikely (< 10%) to hit the
pcoinsTipcheck and then be found. ButpcoinsTipmust check the database to be sure it can't find the transaction. Switching the fullHaveCoinscheck for the fastHaveCoinsInCachecheck will still prevent the vast majority of false negatives but will never need a database access. The downside is after the cache has been flushed there maybe be a very few more cases of requesting already confirmed transactions from peers.