Skip to content

Conversation

@wtogami
Copy link
Contributor

@wtogami wtogami commented Apr 28, 2016

No description provided.

@paveljanik
Copy link
Contributor

utACK 6acd133

@maflcko
Copy link
Member

maflcko commented Apr 29, 2016

utACK 6acd133

@maflcko maflcko added the Docs label Apr 29, 2016
doc/README.md Outdated
Copy link
Member

@laanwj laanwj May 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Good catch - this hasn't been true for a while. We now link qt statically on Linux, so there is no actual need to install any run-time library.
Building is explained in build-unix.md so this part can go entirely (as this is targeted at people installing the binaries).

@laanwj
Copy link
Member

laanwj commented May 2, 2016

Changes to build-unix.md ACK

@wtogami
Copy link
Contributor Author

wtogami commented May 2, 2016

OK, so you want removal of stuff from doc/README.md, will do.

@laanwj
Copy link
Member

laanwj commented May 4, 2016

Yes, either you should remove it or leave it alone (to be cleaned up by someone else). Extending it at least makes no sense.

@wtogami wtogami force-pushed the fedora_build_readme branch from 6acd133 to 0281678 Compare May 4, 2016 18:57
@wtogami
Copy link
Contributor Author

wtogami commented May 4, 2016

Force pushed to update only the build requirements. doc/README.md should be cleaned up separately.

@laanwj laanwj merged commit 0281678 into bitcoin:master May 5, 2016
laanwj added a commit that referenced this pull request May 5, 2016
0281678 doc: Fedora build requirements (Warren Togami)

To build with Qt 5 (recommended) you need the following:

sudo dnf install qt5-qttools-devel qtr5-qtbase-devel protobuf-devel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/qtr5/qt5/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

codablock pushed a commit to codablock/dash that referenced this pull request Dec 20, 2017
0281678 doc: Fedora build requirements (Warren Togami)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants