[0.12.2] backport: [qa] Switch to py3 #8187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
Mf1606-qaPy3Backport
branch
from
a6eee2f to
07a9fb3
Compare
Member
|
Whoa, at some point it seems easier to copy over the RPC tests from master and disable the parts that are not appropriate. |
Member
|
Not sure it's appropriate to add dependencies to stable versions. But otoh, it's just tests... (or does this still work with Py2 as well?) |
Member
Author
|
No, the qa/ subfolder is not compatible. It is either python2 or python3.
|
Member
It's a bit of a grey area, but yes it's "just tests", and in addition to that I think the fact that the RPC tests are never invoked by the build system makes this acceptable. |
Github-Pull: bitcoin#7814 Rebased-From: fa389d4
maflcko
force-pushed
the
Mf1606-qaPy3Backport
branch
from
07a9fb3 to
2826565
Compare
maflcko
changed the title
Member
|
tACK 2826565 |
laanwj
added a commit
that referenced
this pull request
Aug 31, 2016
2826565 [qa] Switch to py3 (MarcoFalke)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github-Pull: #7814
This also includes the other .12 backports but I expect travis to fail on this one.
@laanwj can you try to look into backporting #7723 and a6666b2 if we want to switch to py3 in .12 as well?