Skip to content

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Jun 13, 2016

Draft4 of ax_pthread has been available since February, and is the current version available from gnu.org. It fixes an issue on FreeBSD, so sync our version with upstream.

Whitespaceless diff

@paveljanik
Copy link
Contributor

The non-shitespaced diff 0e209f9?w=0 shows that only serial is bumped up and freebsd removed from some condition.

utACK 0e209f9

But: nobody reported this issue to us anyway. But: why not... I think it makes sense only if we have an issue for such "syncs".

@fanquake
Copy link
Member Author

Yes I'm not sure why there is such a whitespace difference between the actual draft4 and the version available on gnu.org. I guess we could just include the important changes?

@maflcko
Copy link
Member

maflcko commented Jun 14, 2016

utACK 0e209f9

@laanwj
Copy link
Member

laanwj commented Jun 14, 2016

But: nobody reported this issue to us anyway. But: why not... I think it makes sense only if we have an issue for such "syncs".

Agree, I don't think we should do this too often, especially not if the specific issue isn't reported to us.

Maybe it would makes sense to schedule an update of the .m4s once per (major) release or so? And group them together in one pull. To include it in the per-release actions at the top of the release process?

Apart from that, it's harmless (the actual diff is minimal and obvious), so utACK 0e209f9

@laanwj laanwj merged commit 0e209f9 into bitcoin:master Jun 14, 2016
laanwj added a commit that referenced this pull request Jun 14, 2016
0e209f9 [trivial] Sync ax_pthread with upstream draft (fanquake)
@fanquake fanquake deleted the sync-pthread branch June 22, 2016 02:54
codablock pushed a commit to codablock/dash that referenced this pull request Dec 28, 2017
0e209f9 [trivial] Sync ax_pthread with upstream draft (fanquake)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants