Skip to content

Conversation

@isle2983
Copy link
Contributor

The edit history on these three files are from users:

contrib/devtools/security-check.py (@ChoHag, @laanwj, @theuni, @calebogden)
contrib/devtools/test-security-check.py (@ChoHag, @laanwj)
share/qt/extract_strings_qt.py (@ChoHag, @MitchellCash, @laanwj, @luke-jr, @brandondahler, Phillip Kaufmann, @theuni)

As per the threads for PR #7300 and #8676, there are ACKs to add these headers
from all but Philip Kaufmann and @ChoHag.

The specific edits:

@ChoHag edited security-check.py in 7b01ce2 and 873e81f
@ChoHag edited test-security-check.py in 873e81f
@ChoHag edited extract_strings_qt.py in 873e81f
Philip Kaufmann edited extract_strings_qt.py in 01cbaeb

I will make an effort to reach out via email.

@fanquake fanquake added the Docs label Sep 12, 2016
@isle2983
Copy link
Contributor Author

It has been a couple days, and I haven't heard back. For the record, the emails that were sent to the addresses listed in the git commits:

https://gist.github.com/isle2983/1f4bce2eb202553c3e209be5b6606745
https://gist.github.com/isle2983/e84b22121854c56cfe3829f986bcfdf6

If I hear anything, I will post it here ASAP.

The edits to these files are are all 1-liners (7b01ce2, 873e81f, 01cbaeb). IANAL, but I think it is fairly reasonable to conclude that there aren't any IP violations contained in those edits.

I will leave it up to the project leads for whether this is appropriate to merge.

@laanwj
Copy link
Member

laanwj commented Sep 19, 2016

Thanks for trying to organize this. As the original author of security-check.py and test-security-check.sh I think my agreement to add an copyright header is most important, as I should have done that in the first place. The other changes, apart from @theuni's, who also agrees with the MIT license, are just typo and comment fixes so I'm fine with doing this without their agreement.

Same for share/qt/extract_strings_qt.py - except that @luke-jr significantly contributed there too, but he agreed to in previous related pulls. So let's just move on here.

@laanwj laanwj merged commit 4677b19 into bitcoin:master Sep 19, 2016
laanwj added a commit that referenced this pull request Sep 19, 2016
…g Python files

4677b19 [copyright] add MIT License copyright header to remaining Python files (isle2983)
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Sep 21, 2016
codablock pushed a commit to codablock/dash that referenced this pull request Jan 11, 2018
…emaining Python files

4677b19 [copyright] add MIT License copyright header to remaining Python files (isle2983)
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Nov 9, 2018
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
…emaining Python files

4677b19 [copyright] add MIT License copyright header to remaining Python files (isle2983)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants