Add updating of chainTxData to release process #9734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACK |
Contributor
|
ACK 41b8821 |
Member
|
Please also add specific documentation on how to update it. As it is, no one but you can a probably follow that step :) Edit: okay, we can only do that after #9733 or something similar went in. |
Member
Member
|
Eh yes makes sense
…On Fri, Feb 10, 2017 at 6:23 PM, MarcoFalke ***@***.***> wrote:
@laanwj <https://github.com/laanwj> I changed the milestone to 0.15, as
the constants were already updated in #9472
<#9472>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9734 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAHutvBvY8970puCIIkMnsPtno1OXFsTks5rbJ0NgaJpZM4L883l>
.
|
Member
Author
Member
|
ACK 41b8821 |
laanwj
added a commit
that referenced
this pull request
Mar 20, 2017
41b8821 Add updating of chainTxData to release process (Pieter Wuille) Tree-SHA512: f7d6e72b19aa83fc4851a9316d6c6a236e0e914d637525cda42c0b15a94543b8072ce67b57d6b12141332a03b64b6c715dff4d61e6e58e0197b22305b35ad65d
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 6, 2019
41b8821 Add updating of chainTxData to release process (Pieter Wuille) Tree-SHA512: f7d6e72b19aa83fc4851a9316d6c6a236e0e914d637525cda42c0b15a94543b8072ce67b57d6b12141332a03b64b6c715dff4d61e6e58e0197b22305b35ad65d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, the transaction count estimation data in
chainparams.cpp's chainTxData must be updated to reflect reality.These constants were updated in #9472, and the total tx estimate for today is still very close. So I believe that updating once every major release is probably enough.
#9733 can be used to compute updated constants.