[wallet] Remove importmulti always-true check #9760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK ee7caa0 I'd prefer to merge this for 0.14 also so that a future code change doesn't break the rescan because there is no grace period in this check. |
Remove "nLowestTimestamp <= chainActive.Tip()->GetBlockTimeMax()" check from importmulti, which is always true because nLowestTimestamp is set to the minimum of the most recent block time and all the imported key timestamps, which is necessarily lower than the maximum block time.
ryanofsky
force-pushed
the
pr/multitaut
branch
from
ee7caa0 to
ec1267f
Compare
|
Rebased ee7caa0 -> ec1267f (multitaut.0 -> multitaut.1). Merge conflict was unrelated, but on an adjacent line to this one line change. |
|
utACK ec1267f |
laanwj
added a commit
that referenced
this pull request
Feb 20, 2017
ec1267f [wallet] Remove importmulti always-true check (Russell Yanofsky)
laanwj
pushed a commit
that referenced
this pull request
Feb 20, 2017
Remove "nLowestTimestamp <= chainActive.Tip()->GetBlockTimeMax()" check from importmulti, which is always true because nLowestTimestamp is set to the minimum of the most recent block time and all the imported key timestamps, which is necessarily lower than the maximum block time. Github-Pull: #9760 Rebased-From: ec1267f
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 26, 2018
ec1267f [wallet] Remove importmulti always-true check (Russell Yanofsky)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
ec1267f [wallet] Remove importmulti always-true check (Russell Yanofsky)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 27, 2019
ec1267f [wallet] Remove importmulti always-true check (Russell Yanofsky)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change in behavior.
Remove
nLowestTimestamp <= chainActive.Tip()->GetBlockTimeMax()check fromimportmulti, which is always true because nLowestTimestamp is set to the
minimum of the most recent block time and all the imported key timestamps,
which is necessarily lower than the maximum block time.
An alternative would to make initialize nLowestTimestamp to
numeric_limits<int64_t>::max()so the check would actually do what it appears to be intended to do, and avoid ScanForWalletTransactions calls when all the imported key timestamps are in the future.