Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault crash when shutdown the GUI in disablewallet mode #9817

Merged
merged 1 commit into from
Feb 21, 2017

Conversation

jonasschnelli
Copy link
Contributor

Should fix #9816.
Was introduced in #9190.

@jonasschnelli jonasschnelli added this to the 0.14.0 milestone Feb 21, 2017
@ryanofsky
Copy link
Contributor

Obvious utACK 312c4f1.

Were you planning to add a test? I haven't looked into qt unit testing, but it is nice when simple bugfixes like this are accompanied by tests to increase meaningful test coverage. (It's easy to imagine similar bugs with --disablewallet being introduced in the future.)

@paveljanik
Copy link
Contributor

ACK 312c4f1

Is #9746 the same?

@laanwj
Copy link
Member

laanwj commented Feb 21, 2017

Were you planning to add a test? I haven't looked into qt unit testing, but it is nice when simple bugfixes like this are accompanied by tests to increase meaningful test coverage. (It's easy to imagine similar bugs with --disablewallet being introduced in the future.)

There are unit tests for Qt, but currently nothing that can test window setup/teardown or UI interaction.

@laanwj laanwj merged commit 312c4f1 into bitcoin:master Feb 21, 2017
laanwj added a commit that referenced this pull request Feb 21, 2017
…t mode

312c4f1 Fix segfault crash when shutdown the GUI in disablewallet mode (Jonas Schnelli)
laanwj pushed a commit that referenced this pull request Feb 21, 2017
laanwj pushed a commit that referenced this pull request Feb 21, 2017
@laanwj
Copy link
Member

laanwj commented Feb 21, 2017

Backported to 0.14 as 7d75a5a, 0.13 as c6811c1

@maflcko
Copy link
Member

maflcko commented Feb 23, 2017

@ryanofsky Were you planning to add a test? I haven't looked into qt unit testing, but it is nice when simple bugfixes like this are accompanied by tests to increase meaningful test coverage. (It's easy to imagine similar bugs with --disablewallet being introduced in the future.)

You can run BITCOIND=bitcoin-qt ./qa/pull-tester/rpc-tests.py for basic sanity checking of the gui.

codablock pushed a commit to codablock/dash that referenced this pull request Jan 26, 2018
…lewallet mode

312c4f1 Fix segfault crash when shutdown the GUI in disablewallet mode (Jonas Schnelli)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
…lewallet mode

312c4f1 Fix segfault crash when shutdown the GUI in disablewallet mode (Jonas Schnelli)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019
…lewallet mode

312c4f1 Fix segfault crash when shutdown the GUI in disablewallet mode (Jonas Schnelli)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running with --disablewallet gives a segfault
5 participants