-
Notifications
You must be signed in to change notification settings - Fork 36.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix segfault crash when shutdown the GUI in disablewallet mode #9817
Conversation
Obvious utACK 312c4f1. Were you planning to add a test? I haven't looked into qt unit testing, but it is nice when simple bugfixes like this are accompanied by tests to increase meaningful test coverage. (It's easy to imagine similar bugs with --disablewallet being introduced in the future.) |
There are unit tests for Qt, but currently nothing that can test window setup/teardown or UI interaction. |
…t mode 312c4f1 Fix segfault crash when shutdown the GUI in disablewallet mode (Jonas Schnelli)
You can run |
…lewallet mode 312c4f1 Fix segfault crash when shutdown the GUI in disablewallet mode (Jonas Schnelli)
…lewallet mode 312c4f1 Fix segfault crash when shutdown the GUI in disablewallet mode (Jonas Schnelli)
…lewallet mode 312c4f1 Fix segfault crash when shutdown the GUI in disablewallet mode (Jonas Schnelli)
Should fix #9816.
Was introduced in #9190.