Remove some of the reserves and regtest features #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@notmandatory we need to get this one merged before we can make the CI pass for #99 and #102 .. |
notmandatory
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
ACK 5b20283.
I adjusted the github actions branch rules to match changes in this PR also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the way
ExternalReservesfunctionality is written, it can only be used withelectrumfeature. The tests should fail if the implementation behavior is enforced.. Disabling the tests in CI.Also removing the
regtest-esplorafeatures from the tests, because they won't work when #92 lands.Notes to the reviewers
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing