Wallet Verbosity for PSBT details #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandipan Dey <hey@sandipan.dev>
sandipndev
force-pushed
the
wallet-verbose-json-psbts
branch
from
2870bb2
to
378b33a
Compare
notmandatory
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "wallet" flag
-vor--verbosefor the following offline wallet subcommands: "create_tx", "sign" and "finalize_psbt".Passed
walletOptsdown tohandle_offline_sub_commandsso that the subcommands can access and know if the verbose flag was set in wallet level.This PR addresses the issue brought up in #32.