Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network parser function to lib.rs, remove network parsing from repl.rs #5

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Add network parser function to lib.rs, remove network parsing from repl.rs #5

merged 2 commits into from
Jan 7, 2021

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Dec 28, 2020 •
edited
Loading

Description

This PR moves network parsing to lib.rs and changes repl to return an error instead of defaulting to testnet if an invalid network name is given.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory force-pushed the feat/add_net_parser branch 2 times, most recently from 10e92fe to ea2490e Compare December 28, 2020 07:06
RCasatta
RCasatta reviewed Dec 29, 2020
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@notmandatory
Copy link
Member Author

BTW, I Removed commits to set bdk dependency version to ^0.2 as I don't think we're quite ready for that.

@notmandatory notmandatory force-pushed the feat/add_net_parser branch 2 times, most recently from f1cc0e1 to 4a8d983 Compare December 31, 2020 00:17
@notmandatory notmandatory merged commit b4895c0 into bitcoindevkit:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RCasatta RCasatta RCasatta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notmandatory @RCasatta