Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov to grcov from Tarpauline #58

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

rajarshimaitra
Copy link
Contributor

Description

To match with existing codecov of BDK, Tarpaulin based codecov in bdk-cli is changed to grcov.

Notes to the reviewers

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@rajarshimaitra
Copy link
Contributor Author

Although it seems we haven't been using the codecov reporting lately. There were no codecov reports for previous PRs.

@notmandatory is this intentional or something was off with Tarpaulin?

@notmandatory
Copy link
Member

Looks like a something needs to be done to fix the failure seen here: https://github.com/rajarshimaitra/bdk-cli/runs/4340753274?check_suite_focus=true

This project has a rust-toolchain file that's overriding the nightly toolchain, we either need to remove this file, or add to the codecov job:

rustup override set nightly

@notmandatory
Copy link
Member

Although it seems we haven't been using the codecov reporting lately. There were no codecov reports for previous PRs.

@notmandatory is this intentional or something was off with Tarpaulin?

You mean no codecov reports for bdk-cli lately? I think they're being generated but not displayed inline, here's the latest one that was generated: https://app.codecov.io/gh/bitcoindevkit/bdk-cli/commit/b0c78e0aef181b2156c29549c3e27712166a4e49

@rajarshimaitra
Copy link
Contributor Author

Looks like a something needs to be done to fix the failure seen here:

I am not sure if we need the file. But for now I have set the override in CI.

I think they're being generated but not displayed inline,

Yes the coverage reports are generating fine, but they are not being displayed in PR page here. Also the same for bdk project. Maybe we need to add CodeCov App to github like this? https://docs.codecov.com/docs/how-to-create-a-github-app-for-codecov-enterprise

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 17c9329

Also I think I've enabled the Codecov app for the bitcoindevkit org.. it should activate next time code is pushed to this repo.

@notmandatory
Copy link
Member

This one looks like it needs a rebase to get it to rerun the tests for rust 1.56.1 and then we can merge it.

@rajarshimaitra
Copy link
Contributor Author

Rebased.

@notmandatory notmandatory merged commit efcdf09 into bitcoindevkit:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants