Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to current stable, 1.56.1 #59

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Nov 29, 2021

Description

Update MSRV to the current stable, 1.56.1 and update the cargo.lock file. Also removed the rust-toolchain file.

Notes to the reviewers

I removed the rust-toolchain file because I don't think we need to lock users into a particular version (or force them to override it), and this file seem to primarily be used for projects using a specific nightly release, see: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file.

I also had to pin the fd-lock dependency because of a recent update to that crate to use the rustdoc::missing_doc_code_examples feature which is only supported by nightly 😞 .

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory force-pushed the update_msrv_1561 branch 2 times, most recently from c1563e4 to 65b899b Compare November 29, 2021 23:30
@notmandatory
Copy link
Member Author

Before this is merged we need to change the github expected checks from 1.53.0 to 1.56.1.

@notmandatory notmandatory merged commit 8041290 into bitcoindevkit:master Dec 1, 2021
@notmandatory
Copy link
Member Author

undoing the pinned fd-lock with #64

@notmandatory notmandatory self-assigned this Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant