Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handlings. #61

Merged
merged 1 commit into from
Dec 12, 2021
Merged

Improve error handlings. #61

merged 1 commit into from
Dec 12, 2021

Conversation

rajarshimaitra
Copy link
Contributor

Description

bdk-cli had lots of ugly unwraps through out the code. All the unwraps inside the library (except tests) were removed and errors were propagated with bdk::Error type.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory
Copy link
Member

LGTM but I think it needs a rebase and fixes to pass CI.

@rajarshimaitra
Copy link
Contributor Author

Rebased and conflicts resolved..

@notmandatory notmandatory merged commit f3d126e into bitcoindevkit:master Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rajarshimaitra rajarshimaitra

Labels
None yet
Projects
BDK-CLI Roadmap
Archived in project
Milestone
Release 0.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@rajarshimaitra @notmandatory