-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto deploy regtest nodes in background #65
Auto deploy regtest nodes in background #65
Conversation
381b49f
to
b306bc1
Compare
b306bc1
to
f7ada0c
Compare
Fixed merge conflict with some enhancements. |
f0332f1
to
ac2a6c2
Compare
Updated the commit history for better structuring. |
@rajarshimaitra Looks like this one needs a rebase or if you're tied up I can do the rebase but would have to rewrite your commits. Once that's done I'll do some testing and see if I can figure out how to expose the core rpc in repl mode. |
ac2a6c2
to
ca7b228
Compare
Rebased and resolved conflicts.. |
22f2b7e
to
fefd378
Compare
I spent some time today testing and reviewing and this is a great start! There are still the two (related) issues you found:
I believe issue 2 is because But for now as long as we add the comment that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some little experimental warnings and this is good to go.
fefd378
to
27261a0
Compare
Thanks @notmandatory .. Updated as per suggested and rebased.. |
27261a0
to
143b511
Compare
Rebased on latest master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to do a cargo fmt.
143b511
to
2086c0c
Compare
This adds bitcoind and electrsd deployment and management for each kind of feature flags. The wallet then gets connected to the backend. All the backend related args for bdk-cli can be omitted in regtest-* mode.
2086c0c
to
930b0c4
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 930b0c4
Description
Fixes #55. I decided to go for one feature flag for each backends as they made dependency management easier. Because different backend will have different dependency, and we don't wanna have redundant ones. Also it makes the commands a little shorter.
Notes to the reviewers
Right now its not that useful because the backend APIs are not exposed. So I can't really do much other than sync/send in the command line. (unlike testnet we cannot send coins to bdk from outside of local regtest node). So to make it useful in repl mode as described in the issue, we also have to expose the blockchain apis in bdk-cli command in some way (at least the basic stuffs, address, send, generate). Looking for suggestions on this.
usage looks like this:
Although I am having trouble connecting to the esplora end of electrs. Not sure whats the issue, will have to look more.
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
CHANGELOG.md