Add cookie authentication option for rpc #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajarshimaitra
force-pushed
the
cookie-auth
branch
3 times, most recently
from
b73f92d to
c346915
Compare
notmandatory
added
good first issue
rajarshimaitra
force-pushed
the
cookie-auth
branch
from
c346915 to
82f7ff2
Compare
|
Rebased on master.. Needs review.. |
notmandatory
approved these changes
Feb 12, 2022
There was a problem hiding this comment.
utACK 82f7ff2.
But needs another rebase. After than I'll give it a final test and should be good to merge.
rajarshimaitra
force-pushed
the
cookie-auth
branch
from
82f7ff2 to
a9f14a9
Compare
|
Rebased.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #67
This PR adds an optional
cookiearg to pass on cookie file if user needs to use that instead of basic user:password based authentication.bitcoin core will only generate a
.cookiefile if rpc username passwords are not set inbitcoin.conf. Thus cookie file doesn't have a default. User should only provide it if they know a cookie file exists, or else "File not found" error is returned.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.md