Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Script.to_bytes() method #369

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Expose Script.to_bytes() method #369

merged 2 commits into from
Jun 15, 2023

Conversation

thunderbiscuit
Copy link
Member

This PR exposes the to_bytes() method on the Script type.

Fixes #359.

Changelog notice

APIs Added:
    - Expose Script.to_bytes() method [#369]

[#369]: https://github.com/bitcoindevkit/bdk-ffi/pull/369

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added docs for the new feature

@thunderbiscuit thunderbiscuit self-assigned this Jun 12, 2023
@thunderbiscuit thunderbiscuit added this to the Release 0.29.0 milestone Jun 12, 2023
@thunderbiscuit thunderbiscuit mentioned this pull request Jun 12, 2023
Merged
3 tasks
notmandatory
notmandatory approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 25033f6

@thunderbiscuit thunderbiscuit merged commit 25033f6 into bitcoindevkit:master Jun 15, 2023
@thunderbiscuit thunderbiscuit deleted the script-to-bytes branch November 14, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@thunderbiscuit thunderbiscuit

Labels
None yet
Projects
BDK-Bindings
Archived in project
Milestone
Release 0.29.0
Development

Successfully merging this pull request may close these issues.

Expose as_bytes in Script struct and is_mine in Wallet struct
2 participants
@thunderbiscuit @notmandatory